Skip to content

Conversation

@heljkon
Copy link
Contributor

@heljkon heljkon commented Nov 20, 2025

@heljkon
Copy link
Contributor Author

heljkon commented Nov 22, 2025

Building 10.2.0rc1 fails with:

FAILED: [code=1] qga/vss-win32/qga-vss.dll.p/install.cpp.obj
"c++" "-m64" "-Iqga/vss-win32/qga-vss.dll.p" "-Iqga/vss-win32" "-I../qga/vss-win32" "-I." "-Iqapi" "-Itrace" "-Iui" "-Iui/shader" "-ID:/msys64/ucrt64/include/glib-2.0" "-ID:/msys64/ucrt64/lib/glib-2.0/include" "-fdiagnostics-color=auto" "-D_GLIBCXX_ASSERTIONS=1" "-Wall" "-Winvalid-pch" "-std=gnu++11" "-O2" "-g" "-D__STDC_LIMIT_MACROS" "-D__STDC_CONSTANT_MACROS" "-D__STDC_FORMAT_MACROS" "-fstack-protector-strong" "-Wempty-body" "-Wendif-labels" "-Wexpansion-to-defined" "-Wformat-security" "-Wformat-y2k" "-Wignored-qualifiers" "-Wimplicit-fallthrough=2" "-Winit-self" "-Wmissing-format-attribute" "-Wredundant-decls" "-Wshadow=local" "-Wtype-limits" "-Wundef" "-Wvla" "-Wwrite-strings" "-Wno-missing-include-dirs" "-Wno-psabi" "-Wno-shift-negative-value" "-iquote" "." "-iquote" "D:/msys64/home/Normalo/test/qemu-10.2.0-rc1" "-iquote" "D:/msys64/home/Normalo/test/qemu-10.2.0-rc1/include" "-iquote" "D:/msys64/home/Normalo/test/qemu-10.2.0-rc1/host/include/x86_64" "-iquote" "D:/msys64/home/Normalo/test/qemu-10.2.0-rc1/host/include/generic" "-iquote" "D:/msys64/home/Normalo/test/qemu-10.2.0-rc1/tcg/i386" "-mcx16" "-msse2" "-D_GNU_SOURCE" "-D_FILE_OFFSET_BITS=64" "-D_LARGEFILE_SOURCE" "-fno-strict-aliasing" "-fno-common" "-fwrapv" "-fno-pie" "-no-pie" "-ftrivial-auto-var-init=zero" "-fzero-call-used-regs=used-gpr" "-Wno-unknown-pragmas" "-Wno-delete-non-virtual-dtor" "-Wno-non-virtual-dtor" -MD -MQ qga/vss-win32/qga-vss.dll.p/install.cpp.obj -MF "qga/vss-win32/qga-vss.dll.p/install.cpp.obj.d" -o qga/vss-win32/qga-vss.dll.p/install.cpp.obj "-c" ../qga/vss-win32/install.cpp
../qga/vss-win32/install.cpp:554:17: error: redefinition of 'OLECHAR* _com_util::ConvertStringToBSTR(const char*)'
554 |     BSTR WINAPI ConvertStringToBSTR(const char *ascii) {
   |                 ^~~~~~~~~~~~~~~~~~~
In file included from D:/msys64/ucrt64/include/comdef.h:19,
              from ../qga/vss-win32/install.cpp:24:
D:/msys64/ucrt64/include/comutil.h:55:22: note: 'OLECHAR* _com_util::ConvertStringToBSTR(const char*)' previously defined here
55 |   inline BSTR WINAPI ConvertStringToBSTR(const char *pSrc){
   |                      ^~~~~~~~~~~~~~~~~~~
ninja: build stopped: subcommand failed.

For the failing builds I've created an issue in QEMU Gitlab: https://gitlab.com/qemu-project/qemu/-/issues/3217

@heljkon
Copy link
Contributor Author

heljkon commented Nov 22, 2025

After applying ConvertStringToBSTR.patch all packages were built. QEMU Guest Agent works as expected:

@heljkon
Copy link
Contributor Author

heljkon commented Dec 6, 2025

Building 10.2.0rc2 failed and was fixed by applying patch provided in https://gitlab.com/qemu-project/qemu/-/issues/3234

@heljkon heljkon mentioned this pull request Dec 8, 2025
@heljkon heljkon force-pushed the mingw-w64-qemu-10.2.0-1 branch from 2415114 to bed5daf Compare December 10, 2025 05:05
@heljkon
Copy link
Contributor Author

heljkon commented Dec 10, 2025

After merge of #26774, the PR-branch was rebased to master. So the previously necessary patches are already in master.

@heljkon heljkon force-pushed the mingw-w64-qemu-10.2.0-1 branch from f6faccf to e44e79e Compare December 25, 2025 05:41
@heljkon heljkon force-pushed the mingw-w64-qemu-10.2.0-1 branch from e44e79e to ab27171 Compare December 25, 2025 07:02
@heljkon heljkon marked this pull request as ready for review December 25, 2025 08:29
@heljkon
Copy link
Contributor Author

heljkon commented Dec 25, 2025

@lazka @Biswa96 @MehdiChinoune @jeremyd2019
New QEMU ready to merge. Please review

@MehdiChinoune MehdiChinoune merged commit 06bb119 into msys2:master Dec 26, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants